feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)

* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
This commit is contained in:
Lyndsi Kay Williams
2022-08-01 14:36:34 -05:00
committed by GitHub
parent 3a11856ecb
commit 8a04536f9d
25 changed files with 515 additions and 196 deletions

View File

@@ -48,7 +48,7 @@ export default function sqlLabReducer(state = {}, action) {
existing,
{
remoteId: result.remoteId,
title: query.title,
name: query.name,
},
'id',
);
@@ -71,7 +71,7 @@ export default function sqlLabReducer(state = {}, action) {
);
const qe = {
remoteId: progenitor.remoteId,
title: t('Copy of %s', progenitor.title),
name: t('Copy of %s', progenitor.name),
dbId: action.query.dbId ? action.query.dbId : null,
schema: action.query.schema ? action.query.schema : null,
autorun: true,
@@ -467,7 +467,7 @@ export default function sqlLabReducer(state = {}, action) {
},
[actions.QUERY_EDITOR_SET_TITLE]() {
return alterInArr(state, 'queryEditors', action.queryEditor, {
title: action.title,
name: action.name,
});
},
[actions.QUERY_EDITOR_SET_SQL]() {