QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 17:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): invalid dump sql shown after closing tab (#27295)

Browse Source
This commit is contained in:
JUST.in DO IT
2024-02-29 09:57:30 -08:00
committed by GitHub
parent d65f64d1ce
commit 8d245704ef
5 changed files with 91 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/src/SqlLab/reducers/sqlLab.test.js
View File

@@ -75,6 +75,25 @@ describe('sqlLabReducer', () => {
initialState.queryEditors.length,
);
});
it('should select the latest query editor when tabHistory is empty', () => {
const currentQE = newState.queryEditors[0];
newState = {
...initialState,
tabHistory: [initialState.queryEditors[0]],
};
const action = {
type: actions.REMOVE_QUERY_EDITOR,
queryEditor: currentQE,
};
newState = sqlLabReducer(newState, action);
expect(newState.queryEditors).toHaveLength(
initialState.queryEditors.length - 1,
);
expect(newState.queryEditors.map(qe => qe.id)).not.toContainEqual(
currentQE.id,
);
expect(newState.tabHistory).toEqual([initialState.queryEditors[2].id]);
});
it('should remove a query editor including unsaved changes', () => {
expect(newState.queryEditors).toHaveLength(
initialState.queryEditors.length + 1,