From 8d7ffac94567193f1e769bb61b0d657b22cf26d8 Mon Sep 17 00:00:00 2001 From: Elizabeth Thompson Date: Wed, 6 May 2026 00:35:53 +0000 Subject: [PATCH] fix(reports): log configured timeout value when spinner wait expires Include SCREENSHOT_LOAD_WAIT / load_wait in the warning message so it is immediately visible from logs whether the timeout limit was reached. Also fix stale docstring default value (30 -> 60). Co-Authored-By: Claude Sonnet 4.6 --- superset/utils/screenshot_utils.py | 6 ++++-- superset/utils/webdriver.py | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/superset/utils/screenshot_utils.py b/superset/utils/screenshot_utils.py index 8deada447e7..3cc33fb10fe 100644 --- a/superset/utils/screenshot_utils.py +++ b/superset/utils/screenshot_utils.py @@ -97,7 +97,7 @@ def take_tiled_screenshot( page: Playwright page object element_name: CSS class name of the element to screenshot tile_height: Height of each tile in pixels - load_wait: Seconds to wait for charts to load per tile (default 30) + load_wait: Seconds to wait for charts to load per tile (default 60) Returns: Combined screenshot bytes or None if failed @@ -167,9 +167,11 @@ def take_tiled_screenshot( ) except PlaywrightTimeout: logger.warning( - "Timed out waiting for visible spinners to clear on tile %s/%s", + "Timed out waiting for visible spinners to clear on tile %s/%s " + "(load_wait=%ss)", i + 1, num_tiles, + load_wait, ) # Calculate what portion of the element we want to capture for this tile diff --git a/superset/utils/webdriver.py b/superset/utils/webdriver.py index 29a4afc10f9..ef6bb36aca8 100644 --- a/superset/utils/webdriver.py +++ b/superset/utils/webdriver.py @@ -315,7 +315,10 @@ class WebDriverPlaywright(WebDriverProxy): ) except PlaywrightTimeout: logger.warning( - "Timed out waiting for charts to load at url %s", url + "Timed out waiting for charts to load at url %s " + "(SCREENSHOT_LOAD_WAIT=%ss)", + url, + self._screenshot_load_wait, ) raise