mirror of
https://github.com/apache/superset.git
synced 2026-05-12 19:35:17 +00:00
Address comments
This commit is contained in:
@@ -346,10 +346,13 @@ class DatasourceRestApi(BaseSupersetApi):
|
||||
if not can_read_datasets and not can_read_sv:
|
||||
return self.response(403, message="Access denied")
|
||||
|
||||
result = GetCombinedDatasourceListCommand(
|
||||
args=kwargs.get("rison", {}),
|
||||
can_read_datasets=can_read_datasets,
|
||||
can_read_semantic_views=can_read_sv,
|
||||
).run()
|
||||
try:
|
||||
result = GetCombinedDatasourceListCommand(
|
||||
args=kwargs.get("rison", {}),
|
||||
can_read_datasets=can_read_datasets,
|
||||
can_read_semantic_views=can_read_sv,
|
||||
).run()
|
||||
except ValueError as ex:
|
||||
return self.response(400, message=str(ex))
|
||||
|
||||
return self.response(200, **result)
|
||||
|
||||
@@ -51,9 +51,13 @@ class DatasetListSchema(Schema):
|
||||
description = fields.String(allow_none=True)
|
||||
explore_url = fields.String()
|
||||
database = fields.Method("get_database")
|
||||
catalog = fields.String(allow_none=True)
|
||||
schema = fields.String(allow_none=True)
|
||||
sql = fields.String(allow_none=True)
|
||||
extra = fields.String(allow_none=True)
|
||||
extra = fields.Raw(allow_none=True)
|
||||
default_endpoint = fields.String(allow_none=True)
|
||||
is_sqllab_view = fields.Boolean(allow_none=True)
|
||||
is_managed_externally = fields.Boolean(allow_none=True)
|
||||
owners = fields.Method("get_owners")
|
||||
changed_by_name = fields.String()
|
||||
changed_by = fields.Method("get_changed_by")
|
||||
@@ -106,9 +110,13 @@ class SemanticViewListSchema(Schema):
|
||||
description = fields.String(allow_none=True)
|
||||
explore_url = fields.String()
|
||||
database = fields.Constant(None)
|
||||
catalog = fields.Constant(None)
|
||||
schema = fields.Constant(None)
|
||||
sql = fields.Constant(None)
|
||||
extra = fields.Constant(None)
|
||||
default_endpoint = fields.Constant(None)
|
||||
is_sqllab_view = fields.Constant(False)
|
||||
is_managed_externally = fields.Constant(False)
|
||||
owners = fields.Constant([])
|
||||
changed_by_name = fields.String()
|
||||
changed_by = fields.Method("get_changed_by")
|
||||
|
||||
Reference in New Issue
Block a user