QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: use sqlglot to set limit (#33473)

Browse Source
This commit is contained in:
Beto Dealmeida
2025-05-27 15:20:02 -04:00
committed by GitHub
parent cc8ab2c556
commit 8de58b9848
34 changed files with 573 additions and 557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
superset/db_engine_specs/lib.py
View File

@@ -119,7 +119,7 @@ def diagnose(spec: type[BaseEngineSpec]) -> dict[str, Any]:
output.update(
{
"module": spec.__module__,
"limit_method": spec.limit_method.upper(),
"limit_method": spec.limit_method.value,
"joins": spec.allows_joins,
"subqueries": spec.allows_subqueries,
"alias_in_select": spec.allows_alias_in_select,
@@ -129,7 +129,6 @@ def diagnose(spec: type[BaseEngineSpec]) -> dict[str, Any]:
"order_by_not_in_select": spec.allows_hidden_orderby_agg,
"expressions_in_orderby": spec.allows_hidden_cc_in_orderby,
"cte_in_subquery": spec.allows_cte_in_subquery,
"limit_clause": spec.allow_limit_clause,
"max_column_name": spec.max_column_name_length,
"sql_comments": spec.allows_sql_comments,
"escaped_colons": spec.allows_escaped_colons,
@@ -223,7 +222,7 @@ def generate_table() -> list[list[Any]]:
rows = [] # pylint: disable=redefined-outer-name
rows.append(["Feature"] + list(info)) # header row
rows.append(["Module"] + list(db_info["module"] for db_info in info.values())) # noqa: C400
rows.append(["Module"] + [db_info["module"] for db_info in info.values()])
# descriptive
keys = [
@@ -244,14 +243,14 @@ def generate_table() -> list[list[Any]]:
]
for key in keys:
rows.append(
[DATABASE_DETAILS[key]] + list(db_info[key] for db_info in info.values()) # noqa: C400
[DATABASE_DETAILS[key]] + [db_info[key] for db_info in info.values()]
)
# basic
for time_grain in TimeGrain:
rows.append(
[f"Has time grain {time_grain.name}"]
+ list(db_info["time_grains"][time_grain.name] for db_info in info.values()) # noqa: C400
+ [db_info["time_grains"][time_grain.name] for db_info in info.values()]
)
keys = [
"masked_encrypted_extra",
@@ -259,9 +258,7 @@ def generate_table() -> list[list[Any]]:
"function_names",
]
for key in keys:
rows.append(
[BASIC_FEATURES[key]] + list(db_info[key] for db_info in info.values()) # noqa: C400
)
rows.append([BASIC_FEATURES[key]] + [db_info[key] for db_info in info.values()])
# nice to have
keys = [
@@ -280,8 +277,7 @@ def generate_table() -> list[list[Any]]:
]
for key in keys:
rows.append(
[NICE_TO_HAVE_FEATURES[key]]
+ list(db_info[key] for db_info in info.values()) # noqa: C400
[NICE_TO_HAVE_FEATURES[key]] + [db_info[key] for db_info in info.values()]
)
# advanced
@@ -292,10 +288,10 @@ def generate_table() -> list[list[Any]]:
]
for key in keys:
rows.append(
[ADVANCED_FEATURES[key]] + list(db_info[key] for db_info in info.values()) # noqa: C400
[ADVANCED_FEATURES[key]] + [db_info[key] for db_info in info.values()]
)
rows.append(["Score"] + list(db_info["score"] for db_info in info.values())) # noqa: C400
rows.append(["Score"] + [db_info["score"] for db_info in info.values()])
return rows