diff --git a/superset-frontend/src/common/components/index.tsx b/superset-frontend/src/common/components/index.tsx index 1b460eea3ff..58b9059ff4f 100644 --- a/superset-frontend/src/common/components/index.tsx +++ b/superset-frontend/src/common/components/index.tsx @@ -181,11 +181,14 @@ export const StyledSubMenu = styled(AntdMenu.SubMenu)` & > .ant-menu-submenu-title { padding: 0 ${({ theme }) => theme.gridUnit * 6}px 0 ${({ theme }) => theme.gridUnit * 3}px !important; - svg { + span[role='img'] { position: absolute; - top: ${({ theme }) => theme.gridUnit * 4 + 7}px; - right: ${({ theme }) => theme.gridUnit}px; - width: ${({ theme }) => theme.gridUnit * 6}px; + right: ${({ theme }) => -theme.gridUnit + -2}px; + top: ${({ theme }) => theme.gridUnit * 5.25}px; + svg { + font-size: ${({ theme }) => theme.gridUnit * 6}px; + color: ${({ theme }) => theme.colors.grayscale.base}; + } } & > span { position: relative; diff --git a/superset-frontend/src/components/Menu/LanguagePicker.tsx b/superset-frontend/src/components/Menu/LanguagePicker.tsx index 1f0f49d9bbc..faba09a87ff 100644 --- a/superset-frontend/src/components/Menu/LanguagePicker.tsx +++ b/superset-frontend/src/components/Menu/LanguagePicker.tsx @@ -19,7 +19,7 @@ import React from 'react'; import { MainNav as Menu } from 'src/common/components'; import { styled } from '@superset-ui/core'; -import Icon from 'src/components/Icon'; +import Icons from 'src/components/Icons'; const { SubMenu } = Menu; @@ -66,7 +66,7 @@ export default function LanguagePicker(props: LanguagePickerProps) { } - icon={} + icon={} {...rest} > {Object.keys(languages).map(langKey => ( diff --git a/superset-frontend/src/components/Menu/Menu.tsx b/superset-frontend/src/components/Menu/Menu.tsx index 38c826b5ce4..ab496eef749 100644 --- a/superset-frontend/src/components/Menu/Menu.tsx +++ b/superset-frontend/src/components/Menu/Menu.tsx @@ -24,7 +24,7 @@ import { getUrlParam } from 'src/utils/urlUtils'; import { MainNav as DropdownMenu, MenuMode } from 'src/common/components'; import { Link } from 'react-router-dom'; import { Row, Col, Grid } from 'antd'; -import Icon from 'src/components/Icon'; +import Icons from 'src/components/Icons'; import RightMenu from './MenuRight'; import { Languages } from './LanguagePicker'; import { URL_PARAMS } from '../../constants'; @@ -189,7 +189,11 @@ export function Menu({ ); } return ( - }> + : } + > {childs?.map((child: MenuObjectChildProps | string, index1: number) => { if (typeof child === 'string' && child === '-') { return ; diff --git a/superset-frontend/src/components/Menu/MenuRight.tsx b/superset-frontend/src/components/Menu/MenuRight.tsx index 0507097343b..55316024daa 100644 --- a/superset-frontend/src/components/Menu/MenuRight.tsx +++ b/superset-frontend/src/components/Menu/MenuRight.tsx @@ -20,7 +20,7 @@ import React from 'react'; import { MainNav as Menu } from 'src/common/components'; import { t, styled, css, SupersetTheme } from '@superset-ui/core'; import { Link } from 'react-router-dom'; -import Icon from 'src/components/Icon'; +import Icons from 'src/components/Icons'; import LanguagePicker from './LanguagePicker'; import { NavBarProps, MenuObjectProps } from './Menu'; @@ -92,7 +92,7 @@ const RightMenu = ({ title={ } - icon={} + icon={} > {dropdownItems.map(menu => ( @@ -107,7 +107,7 @@ const RightMenu = ({ ))} )} - }> + }> {settings.map((section, index) => [ {section.childs?.map(child => {