refactor: preparation for time section migration (#21766)

This commit is contained in:
Yongjie Zhao
2022-10-12 08:38:30 +08:00
committed by GitHub
parent bd3166b603
commit 8f61e3c5d9
43 changed files with 416 additions and 377 deletions

View File

@@ -20,9 +20,8 @@ import {
AdhocColumn,
buildQueryContext,
ensureIsArray,
FeatureFlag,
getMetricLabel,
isFeatureEnabled,
hasGenericChartAxes,
isPhysicalColumn,
QueryMode,
QueryObject,
@@ -104,7 +103,7 @@ const buildQuery: BuildQuery<TableChartFormData> = (
if (
isPhysicalColumn(col) &&
formData.time_grain_sqla &&
isFeatureEnabled(FeatureFlag.GENERIC_CHART_AXES) &&
hasGenericChartAxes &&
formData?.datetime_columns_lookup?.[col]
) {
return {

View File

@@ -23,6 +23,7 @@ import {
ensureIsArray,
FeatureFlag,
GenericDataType,
hasGenericChartAxes,
isAdhocColumn,
isFeatureEnabled,
isPhysicalColumn,
@@ -189,7 +190,7 @@ const config: ControlPanelConfig = {
},
],
[
isFeatureEnabled(FeatureFlag.GENERIC_CHART_AXES) && isAggMode
hasGenericChartAxes && isAggMode
? {
name: 'time_grain_sqla',
config: {
@@ -217,9 +218,7 @@ const config: ControlPanelConfig = {
},
}
: null,
isFeatureEnabled(FeatureFlag.GENERIC_CHART_AXES) && isAggMode
? 'datetime_columns_lookup'
: null,
hasGenericChartAxes && isAggMode ? 'datetime_columns_lookup' : null,
],
[
{