QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(dao/command): Add transaction decorator to try to enforce "unit of work" (#24969)

Browse Source
This commit is contained in:
John Bodley
2024-06-28 12:33:56 -07:00
committed by GitHub
parent a3f0d00714
commit 8fb8199a55
151 changed files with 681 additions and 916 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/row_level_security/api.py
View File

@@ -23,6 +23,7 @@ from flask_appbuilder.api import expose, protect, rison, safe
from flask_appbuilder.models.sqla.interface import SQLAInterface
from flask_babel import ngettext
from marshmallow import ValidationError
from sqlalchemy.exc import SQLAlchemyError
from superset.commands.exceptions import (
DatasourceNotFoundValidationError,
@@ -34,7 +35,6 @@ from superset.commands.security.exceptions import RLSRuleNotFoundError
from superset.commands.security.update import UpdateRLSRuleCommand
from superset.connectors.sqla.models import RowLevelSecurityFilter
from superset.constants import MODEL_API_RW_METHOD_PERMISSION_MAP, RouteMethod
from superset.daos.exceptions import DAOCreateFailedError, DAOUpdateFailedError
from superset.extensions import event_logger
from superset.row_level_security.schemas import (
get_delete_ids_schema,
@@ -205,7 +205,7 @@ class RLSRestApi(BaseSupersetModelRestApi):
exc_info=True,
)
return self.response_422(message=str(ex))
except DAOCreateFailedError as ex:
except SQLAlchemyError as ex:
logger.error(
"Error creating RLS rule %s: %s",
self.__class__.__name__,
@@ -291,7 +291,7 @@ class RLSRestApi(BaseSupersetModelRestApi):
exc_info=True,
)
return self.response_422(message=str(ex))
except DAOUpdateFailedError as ex:
except SQLAlchemyError as ex:
logger.error(
"Error updating RLS rule %s: %s",
self.__class__.__name__,