[refactor] Migrate from Mocha+Chai to Jest (#6079)

* [refactor] Migrate from Mocha+Chai to Jest

This change migrates all the existing unit tests
- to Jest's global expect and matchers from chai's imported expect, asserts and matchers.
- to Jest's describe/test from mocha's describe/it

The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks:
1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank.
2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :)

This change also removes dependencies to Mocha and Chai.

* Remove the test:one command as it now does the same thing as test.

* Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix`

The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.

* Adding eslint-plugin-jest and further modify tests.

- One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing.
- Deletion of a duplicated test caught by eslint-plugin-jest.

* - Make istanbul coverage work with Jest.

- Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!

* Attempt to fix dynamic imports in tests.

* run sequentially and log heap usage

* - tweaking maxworkers for travis and specifying coverageDirectory for codecov

- remove dynamic import in shim.js now that it is set in babelrc for tests only.
This commit is contained in:
Christine Chambers
2018-10-15 13:10:18 -07:00
committed by Chris Williams
parent 46c86672c8
commit 9029701f24
177 changed files with 2539 additions and 2166 deletions

View File

@@ -1,7 +1,6 @@
import React from 'react';
import { shallow } from 'enzyme';
import sinon from 'sinon';
import { expect } from 'chai';
import $ from 'jquery';
import { table, defaultQueryEditor, databases, tables } from './fixtures';
@@ -36,10 +35,10 @@ describe('SqlEditorLeftBar', () => {
it('is valid', () => {
expect(
React.isValidElement(<SqlEditorLeftBar {...mockedProps} />),
).to.equal(true);
).toBe(true);
});
it('renders a TableElement', () => {
expect(wrapper.find(TableElement)).to.have.length(1);
expect(wrapper.find(TableElement)).toHaveLength(1);
});
describe('onDatabaseChange', () => {
it('should fetch tables', () => {
@@ -47,21 +46,21 @@ describe('SqlEditorLeftBar', () => {
sinon.stub(wrapper.instance(), 'fetchSchemas');
wrapper.instance().onDatabaseChange({ value: 1, label: 'main' });
expect(wrapper.instance().fetchTables.getCall(0).args[0]).to.equal(1);
expect(wrapper.instance().fetchSchemas.getCall(0).args[0]).to.equal(1);
expect(wrapper.instance().fetchTables.getCall(0).args[0]).toBe(1);
expect(wrapper.instance().fetchSchemas.getCall(0).args[0]).toBe(1);
wrapper.instance().fetchTables.restore();
wrapper.instance().fetchSchemas.restore();
});
it('should clear tableOptions', () => {
wrapper.instance().onDatabaseChange();
expect(wrapper.state().tableOptions).to.deep.equal([]);
expect(wrapper.state().tableOptions).toEqual([]);
});
});
describe('getTableNamesBySubStr', () => {
it('should handle empty', () => (
wrapper.instance().getTableNamesBySubStr('')
.then((data) => {
expect(data).to.deep.equal({ options: [] });
expect(data).toEqual({ options: [] });
})
));
it('should handle table name', () => {
@@ -80,14 +79,14 @@ describe('SqlEditorLeftBar', () => {
return wrapper.instance().getTableNamesBySubStr('my table')
.then((data) => {
expect(ajaxStub.getCall(0).args[0]).to.equal('/superset/tables/1/main/my table');
expect(data).to.deep.equal(mockTableOptions);
expect(ajaxStub.getCall(0).args[0]).toBe('/superset/tables/1/main/my table');
expect(data).toEqual(mockTableOptions);
});
});
});
it('dbMutator should build databases options', () => {
const options = wrapper.instance().dbMutator(databases);
expect(options).to.deep.equal([
expect(options).toEqual([
{ value: 1, label: 'main' },
{ value: 208, label: 'Presto - Gold' },
]);
@@ -95,8 +94,8 @@ describe('SqlEditorLeftBar', () => {
describe('fetchTables', () => {
it('should clear table options', () => {
wrapper.instance().fetchTables(1);
expect(wrapper.state().tableOptions).to.deep.equal([]);
expect(wrapper.state().filterOptions).to.be.a('null');
expect(wrapper.state().tableOptions).toEqual([]);
expect(wrapper.state().filterOptions).toBeNull();
});
it('should fetch table options', () => {
ajaxStub.callsFake(() => {
@@ -106,8 +105,8 @@ describe('SqlEditorLeftBar', () => {
});
wrapper.instance().fetchTables(1, 'main', 'birth_names');
expect(ajaxStub.getCall(0).args[0]).to.equal('/superset/tables/1/main/birth_names/');
expect(wrapper.state().tableLength).to.equal(3);
expect(ajaxStub.getCall(0).args[0]).toBe('/superset/tables/1/main/birth_names/');
expect(wrapper.state().tableLength).toBe(3);
});
it('should handle error', () => {
ajaxStub.callsFake(() => {
@@ -116,8 +115,8 @@ describe('SqlEditorLeftBar', () => {
return d.promise();
});
wrapper.instance().fetchTables(1, 'main', 'birth_names');
expect(wrapper.state().tableOptions).to.deep.equal([]);
expect(wrapper.state().tableLength).to.equal(0);
expect(wrapper.state().tableOptions).toEqual([]);
expect(wrapper.state().tableLength).toBe(0);
});
});
describe('fetchSchemas', () => {
@@ -131,8 +130,8 @@ describe('SqlEditorLeftBar', () => {
return d.promise();
});
wrapper.instance().fetchSchemas(1);
expect(ajaxStub.getCall(0).args[0]).to.equal('/superset/schemas/1/false/');
expect(wrapper.state().schemaOptions).to.have.length(3);
expect(ajaxStub.getCall(0).args[0]).toBe('/superset/schemas/1/false/');
expect(wrapper.state().schemaOptions).toHaveLength(3);
});
it('should handle error', () => {
ajaxStub.callsFake(() => {
@@ -141,7 +140,7 @@ describe('SqlEditorLeftBar', () => {
return d.promise();
});
wrapper.instance().fetchSchemas(123);
expect(wrapper.state().schemaOptions).to.deep.equal([]);
expect(wrapper.state().schemaOptions).toEqual([]);
});
});
describe('changeTable', () => {
@@ -156,23 +155,23 @@ describe('SqlEditorLeftBar', () => {
value: 'birth_names',
label: 'birth_names',
});
expect(wrapper.state().tableName).to.equal('birth_names');
expect(wrapper.state().tableName).toBe('birth_names');
});
it('test 2', () => {
wrapper.instance().changeTable({
value: 'main.my_table',
label: 'my_table',
});
expect(wrapper.instance().fetchTables.getCall(0).args[1]).to.equal('main');
expect(wrapper.instance().fetchTables.getCall(0).args[1]).toBe('main');
});
});
it('changeSchema', () => {
sinon.stub(wrapper.instance(), 'fetchTables');
wrapper.instance().changeSchema({ label: 'main', value: 'main' });
expect(wrapper.instance().fetchTables.getCall(0).args[1]).to.equal('main');
expect(wrapper.instance().fetchTables.getCall(0).args[1]).toBe('main');
wrapper.instance().changeSchema();
expect(wrapper.instance().fetchTables.getCall(1).args[1]).to.be.a('null');
expect(wrapper.instance().fetchTables.getCall(1).args[1]).toBeNull();
wrapper.instance().fetchTables.restore();
});