QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-10 11:55:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

[js-testing] more tests for SelectControl (#2877)

Browse Source 
* rename spec folder

* remove special handling for viz_type control since it now uses VizTypeControl

* add test for getOptions

* linting

* add test for cwp

* linting
This commit is contained in:
Alanna Scott
2017-05-31 10:52:02 -07:00
committed by GitHub
parent 1e7773eb16
commit 90e4d6469d
21 changed files with 80 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
superset/assets/javascripts/explore/components/controls/SelectControl.jsx
View File

@@ -34,7 +34,6 @@ export default class SelectControl extends React.PureComponent {
super(props);
this.state = { options: this.getOptions(props) };
this.onChange = this.onChange.bind(this);
this.renderOption = this.renderOption.bind(this);
}
componentWillReceiveProps(nextProps) {
if (nextProps.choices !== this.props.choices) {
@@ -60,7 +59,6 @@ export default class SelectControl extends React.PureComponent {
value: c[0],
label,
};
if (c[2]) option.imgSrc = c[2];
} else if (Object.is(c)) {
option = c;
} else {
@@ -88,17 +86,6 @@ export default class SelectControl extends React.PureComponent {
}
return options;
}
renderOption(opt) {
if (opt.imgSrc) {
return (
<div>
<img className="viz-thumb-option" src={opt.imgSrc} alt={opt.value} />
<span>{opt.label}</span>
</div>
);
}
return opt.label;
}
render() {
// Tab, comma or Enter will trigger a new option created for FreeFormSelect
const selectProps = {
@@ -111,7 +98,7 @@ export default class SelectControl extends React.PureComponent {
clearable: this.props.clearable,
isLoading: this.props.isLoading,
onChange: this.onChange,
optionRenderer: this.renderOption,
optionRenderer: () => opt.label,
};
// Tab, comma or Enter will trigger a new option created for FreeFormSelect
const selectWrap = this.props.freeForm ?