fix: pass string to process_template (#31329)

This commit is contained in:
Beto Dealmeida
2024-12-07 09:49:49 -05:00
committed by GitHub
parent 592564b623
commit 9315a8838c
2 changed files with 29 additions and 5 deletions

View File

@@ -17,7 +17,7 @@
# pylint: disable=invalid-name, redefined-outer-name, too-many-lines
from typing import Optional
from unittest.mock import Mock
from unittest import mock
import pytest
import sqlparse
@@ -1888,12 +1888,33 @@ SELECT * FROM t"""
],
)
def test_extract_tables_from_jinja_sql(
engine: str, macro: str, expected: set[Table]
mocker: MockerFixture,
engine: str,
macro: str,
expected: set[Table],
) -> None:
assert (
extract_tables_from_jinja_sql(
sql=f"'{{{{ {engine}.{macro} }}}}'",
database=Mock(),
database=mocker.Mock(),
)
== expected
)
@mock.patch.dict(
"superset.extensions.feature_flag_manager._feature_flags",
{"ENABLE_TEMPLATE_PROCESSING": False},
clear=True,
)
def test_extract_tables_from_jinja_sql_disabled(mocker: MockerFixture) -> None:
"""
Test the function when the feature flag is disabled.
"""
database = mocker.Mock()
database.db_engine_spec.engine = "mssql"
assert extract_tables_from_jinja_sql(
sql="SELECT 1 FROM t",
database=database,
) == {Table("t")}