QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 23:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Replace react-bootstrap dialogs with Antd dialogs (#11527)

Browse Source 
* Refactor Dialogs in dashboard properties modal

* Refactor Dialogs in explore properties modal

* Refactor dialogs in DatasourceModal

* Refactor dialogs in ExploreResultsButton

* Remove react-bootstrap-dialog from ExploreCtasResultsButton

* Remove react-bootstrap-dialog dependency

* Remove unnecessary functions from Modal

* Bump antd version to fix a bug

* Fix unit tests

* Fix e2e test

* Change antd version to 4.5.4 to fix tests

* Reenable all tests in control

* Another version bump to fix tests
This commit is contained in:
Kamil Gabryjelski
2020-11-04 07:07:21 +01:00
committed by GitHub
parent 1ebeffa104
commit 937f9ca277
11 changed files with 617 additions and 434 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/spec/javascripts/dashboard/components/PropertiesModal_spec.jsx
View File

@@ -26,6 +26,7 @@ import {
ThemeProvider,
} from '@superset-ui/core';
import Modal from 'src/common/components/Modal';
import PropertiesModal from 'src/dashboard/components/PropertiesModal';
import { mockStore } from '../fixtures/mockStore';
@@ -118,7 +119,7 @@ describe('PropertiesModal', () => {
const wrapper = setup();
const modalInstance = wrapper.find('PropertiesModal').instance();
it('will raise an error', () => {
const spy = jest.spyOn(modalInstance.dialog, 'show');
const spy = jest.spyOn(Modal, 'error');
expect(() =>
modalInstance.onColorSchemeChange('THIS_WILL_NOT_WORK'),
).toThrowError('A valid color scheme is required');