QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sqllab] some frontend tests (#1400)

Browse Source 
* [sqllab] some frontend tests

* linting

* Addressing comments

* Addressing unaddressed comments

* Touchups
This commit is contained in:
Maxime Beauchemin
2016-10-25 16:44:32 -07:00
committed by GitHub
parent 7c5933732b
commit 940659bc14
44 changed files with 875 additions and 558 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
caravel/assets/javascripts/SqlLab/components/CopyQueryTabUrl.jsx
View File

@@ -3,11 +3,11 @@ import CopyToClipboard from '../../components/CopyToClipboard';
import { getShortUrl } from '../../../utils/common';
const propTypes = {
qe: React.PropTypes.object,
queryEditor: React.PropTypes.object,
};
const defaultProps = {
qe: null,
queryEditor: null,
};
export default class CopyQueryTabUrl extends React.Component {
@@ -20,7 +20,7 @@ export default class CopyQueryTabUrl extends React.Component {
componentWillMount() {
const params = [];
const qe = this.props.qe;
const qe = this.props.queryEditor;
if (qe.dbId) params.push('dbid=' + qe.dbId);
if (qe.title) params.push('title=' + encodeURIComponent(qe.title));
if (qe.schema) params.push('schema=' + encodeURIComponent(qe.schema));