[sqllab] some frontend tests (#1400)

* [sqllab] some frontend tests

* linting

* Addressing comments

* Addressing unaddressed comments

* Touchups

caravel/assets/javascripts/SqlLab/components/VisualizeModal.jsx

@@ -1,10 +1,6 @@
 import React from 'react';
 import { Alert, Button, Col, Modal } from 'react-bootstrap';
 
-import { connect } from 'react-redux';
-import { bindActionCreators } from 'redux';
-import * as Actions from '../actions';
-
 import Select from 'react-select';
 import { Table } from 'reactable';
 import shortid from 'shortid';
@@ -16,6 +12,17 @@ const CHART_TYPES = [
   { value: 'bar', label: 'Time Series - Bar Chart', requiresTime: true },
 ];
 
+const propTypes = {
+  onHide: React.PropTypes.func,
+  query: React.PropTypes.object,
+  show: React.PropTypes.bool,
+};
+const defaultProps = {
+  show: false,
+  query: {},
+  onHide: () => {},
+};
+
 class VisualizeModal extends React.Component {
   constructor(props) {
     super(props);
@@ -34,7 +41,10 @@ class VisualizeModal extends React.Component {
     this.validate();
   }
   setStateFromProps() {
-    if (!this.props.query || !this.props.query.results.columns) {
+    if (
+        !this.props.query ||
+        !this.props.query.results ||
+        !this.props.query.results.columns) {
       return;
     }
     const columns = {};
@@ -204,22 +214,7 @@ class VisualizeModal extends React.Component {
     return modal;
   }
 }
-VisualizeModal.propTypes = {
-  query: React.PropTypes.object,
-  show: React.PropTypes.bool,
-  onHide: React.PropTypes.func,
-};
-VisualizeModal.defaultProps = {
-  show: false,
-  onHide: () => {},
-};
+VisualizeModal.propTypes = propTypes;
+VisualizeModal.defaultProps = defaultProps;
 
-function mapStateToProps() {
-  return {};
-}
-function mapDispatchToProps(dispatch) {
-  return {
-    actions: bindActionCreators(Actions, dispatch),
-  };
-}
-export default connect(mapStateToProps, mapDispatchToProps)(VisualizeModal);
+export default VisualizeModal;