QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 01:24:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Add explicit ON DELETE CASCADE for dashboard_slices (#24938)

Browse Source
This commit is contained in:
John Bodley
2023-08-10 06:56:11 -07:00
committed by GitHub
parent 284c12697b
commit 94c595093b
9 changed files with 58 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset/daos/chart.py
View File

@@ -43,9 +43,6 @@ class ChartDAO(BaseDAO[Slice]):
def delete(cls, items: Slice | list[Slice], commit: bool = True) -> None:
item_ids = [item.id for item in get_iterable(items)]
# bulk delete, first delete related data
for item in get_iterable(items):
item.dashboards = []
db.session.merge(item)
# bulk delete itself
try:
db.session.query(Slice).filter(Slice.id.in_(item_ids)).delete(