From 94cfefeaa6f7bbaa8a559fe8f93b5cb86a4c00a8 Mon Sep 17 00:00:00 2001 From: Mehmet Salih Yavuz Date: Fri, 8 May 2026 10:43:38 +0300 Subject: [PATCH] fix(table): consolidate visual column options under Visual formatting section (#39856) (cherry picked from commit 69fbbfd7cef892f46c0c7ed1fe4b2cd2ef47116a) --- .../src/controlPanel.tsx | 18 +++++++++--------- .../plugin-chart-table/src/controlPanel.tsx | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx index b3961b61971..7e2ca5a24b1 100644 --- a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx @@ -497,6 +497,12 @@ const config: ControlPanelConfig = { }, }, ], + ], + }, + { + label: t('Visual formatting'), + expanded: true, + controlSetRows: [ [ { name: 'column_config', @@ -590,18 +596,12 @@ const config: ControlPanelConfig = { }, }, ], - ], - }, - { - label: t('Visual formatting'), - expanded: true, - controlSetRows: [ [ { name: 'show_cell_bars', config: { type: 'CheckboxControl', - label: t('Show cell bars'), + label: t('Show cell bars for all columns'), renderTrigger: true, default: true, description: t( @@ -615,7 +615,7 @@ const config: ControlPanelConfig = { name: 'align_pn', config: { type: 'CheckboxControl', - label: t('Align +/-'), + label: t('Align +/- for all columns'), renderTrigger: true, default: false, description: t( @@ -629,7 +629,7 @@ const config: ControlPanelConfig = { name: 'color_pn', config: { type: 'CheckboxControl', - label: t('Add colors to cell bars for +/-'), + label: t('Add colors to cell bars for +/- for all columns'), renderTrigger: true, default: true, description: t( diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx index dd6f6d598fa..0d0f8f76cf5 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx @@ -554,6 +554,12 @@ const config: ControlPanelConfig = { }, }, ], + ], + }, + { + label: t('Visual formatting'), + expanded: true, + controlSetRows: [ [ { name: 'column_config', @@ -650,18 +656,12 @@ const config: ControlPanelConfig = { }, }, ], - ], - }, - { - label: t('Visual formatting'), - expanded: true, - controlSetRows: [ [ { name: 'show_cell_bars', config: { type: 'CheckboxControl', - label: t('Show cell bars'), + label: t('Show cell bars for all columns'), renderTrigger: true, default: true, description: t( @@ -675,7 +675,7 @@ const config: ControlPanelConfig = { name: 'align_pn', config: { type: 'CheckboxControl', - label: t('Align +/-'), + label: t('Align +/- for all columns'), renderTrigger: true, default: false, description: t( @@ -689,7 +689,7 @@ const config: ControlPanelConfig = { name: 'color_pn', config: { type: 'CheckboxControl', - label: t('Add colors to cell bars for +/-'), + label: t('Add colors to cell bars for +/- for all columns'), renderTrigger: true, default: true, description: t(