QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: engines that don't support comments (#13153)

Browse Source 
* fix: engines that don't support comments

* fix: engines that don't support comments

* add quick inexpensive test

* add test
This commit is contained in:
Daniel Vaz Gaspar
2021-02-17 18:01:34 +00:00
committed by GitHub
parent e1bb7f4364
commit 9568985b7b
5 changed files with 53 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/db_engine_specs/elasticsearch_tests.py
View File

@@ -14,6 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from unittest.mock import MagicMock
from sqlalchemy import column
from superset.db_engine_specs.elasticsearch import (
@@ -54,3 +56,15 @@ class TestElasticSearchDbEngineSpec(TestDbEngineSpec):
for original, expected in test_cases.items():
actual = OpenDistroEngineSpec.make_label_compatible(column(original).name)
self.assertEqual(actual, expected)
def test_opendistro_strip_comments(self):
"""
DB Eng Specs (opendistro): Test execute sql strip comments
"""
mock_cursor = MagicMock()
mock_cursor.execute.return_value = []
OpenDistroEngineSpec.execute(
mock_cursor, "-- some comment \nSELECT 1\n --other comment"
)
mock_cursor.execute.assert_called_once_with("SELECT 1\n")