From 95d1f6b69974416375eeebcfbece49ce43bce5a4 Mon Sep 17 00:00:00 2001
From: Evan <evan@preset.io>
Date: Sat, 11 Jul 2026 17:18:28 -0700
Subject: [PATCH] fix(i18n): annotate remaining language-pack locals

Add explicit type hints to the local variables left un-annotated in the
language-pack view and its tests, matching the typed style already used
for their neighbors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 superset/views/core.py                              | 8 ++++----
 tests/unit_tests/views/test_bootstrap_auth.py       | 4 ++--
 tests/unit_tests/views/test_language_pack_script.py | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 042ce6d2376..b58d3520f94 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -22,7 +22,7 @@ import logging
 import os
 import re
 from datetime import datetime
-from typing import Any, Callable, cast
+from typing import Any, Callable, cast, Optional
 from urllib import parse
 
 from flask import (
@@ -952,18 +952,18 @@ class Superset(BaseSupersetView):
         if not re.match(r"^[0-9a-f]{12}$", version):
             abort(400, "Invalid language pack version")
 
-        current_version = get_language_pack_version(lang)
+        current_version: Optional[str] = get_language_pack_version(lang)
         if current_version is None:
             return json_error_response(
                 "Language pack doesn't exist on the server", status=404
             )
-        pack = get_language_pack(lang)
+        pack: Optional[dict[str, Any]] = get_language_pack(lang)
         if pack is None:
             return json_error_response(
                 "Language pack doesn't exist on the server", status=404
             )
 
-        response = Response(
+        response: Response = Response(
             f"window.__SUPERSET_LANGUAGE_PACK__ = {json.dumps(pack)};",
             mimetype="application/javascript; charset=utf-8",
         )
diff --git a/tests/unit_tests/views/test_bootstrap_auth.py b/tests/unit_tests/views/test_bootstrap_auth.py
index e20306c2adc..269ece0aff1 100644
--- a/tests/unit_tests/views/test_bootstrap_auth.py
+++ b/tests/unit_tests/views/test_bootstrap_auth.py
@@ -177,7 +177,7 @@ def test_common_bootstrap_payload_does_not_embed_language_pack(
         patch("superset.views.base.utils.get_user_id", return_value=1),
         patch("superset.views.base.get_locale", return_value="fr"),
     ):
-        payload = common_bootstrap_payload()
+        payload: dict[str, Any] = common_bootstrap_payload()
 
     assert payload["language_pack"] is None
 
@@ -195,7 +195,7 @@ def test_common_bootstrap_payload_preserves_override_pack(
         patch("superset.views.base.utils.get_user_id", return_value=1),
         patch("superset.views.base.get_locale", return_value="fr"),
     ):
-        payload = common_bootstrap_payload()
+        payload: dict[str, Any] = common_bootstrap_payload()
 
     assert payload["language_pack"] == fake_pack
 
diff --git a/tests/unit_tests/views/test_language_pack_script.py b/tests/unit_tests/views/test_language_pack_script.py
index 5e6575e65af..453e80c3f7e 100644
--- a/tests/unit_tests/views/test_language_pack_script.py
+++ b/tests/unit_tests/views/test_language_pack_script.py
@@ -107,9 +107,9 @@ def test_spa_template_loads_pack_before_entry_bundle() -> None:
     ).read_text()
 
     tag_start: int = template.index('<script src="{{ language_pack_src }}"')
-    entry_start = template.index("js_bundle(assets_prefix, entry)")
+    entry_start: int = template.index("js_bundle(assets_prefix, entry)")
     assert tag_start < entry_start
 
-    script_tag = template[tag_start : template.index(">", tag_start)]
+    script_tag: str = template[tag_start : template.index(">", tag_start)]
     assert "async" not in script_tag
     assert "defer" not in script_tag