refactor(explore): move MetricControl and FilterControl to sub-component (#12446)

* wip * wip * wip * wip * move spec * wip * wip * remove unused file * wip * wip * Update superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Update superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Update superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2026-04-23 01:55:09 +00:00 · 2021-01-19 22:46:28 +08:00
parent 84266bfa9e
commit 9771b82c94
41 changed files with 130 additions and 120 deletions
--- a/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsx
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import PropTypes from 'prop-types';
+import columnType from 'src/explore/propTypes/columnType';
+import { DraggableOptionControlLabel } from 'src/explore/components/OptionControls';
+import { OPTION_TYPES } from 'src/explore/components/optionTypes';
+import AdhocMetricOption from './AdhocMetricOption';
+import AdhocMetric from './AdhocMetric';
+import savedMetricType from './savedMetricType';
+import adhocMetricType from './adhocMetricType';
+
+const propTypes = {
+  option: PropTypes.oneOfType([savedMetricType, adhocMetricType]).isRequired,
+  index: PropTypes.number.isRequired,
+  onMetricEdit: PropTypes.func,
+  onRemoveMetric: PropTypes.func,
+  onMoveLabel: PropTypes.func,
+  onDropLabel: PropTypes.func,
+  columns: PropTypes.arrayOf(columnType),
+  savedMetrics: PropTypes.arrayOf(savedMetricType),
+  multi: PropTypes.bool,
+  datasourceType: PropTypes.string,
+};
+
+export default function MetricDefinitionValue({
+  option,
+  onMetricEdit,
+  onRemoveMetric,
+  columns,
+  savedMetrics,
+  datasourceType,
+  onMoveLabel,
+  onDropLabel,
+  index,
+}) {
+  const getSavedMetricByName = metricName =>
+    savedMetrics.find(metric => metric.metric_name === metricName);
+
+  let savedMetric;
+  if (option.metric_name) {
+    savedMetric = option;
+  } else if (typeof option === 'string') {
+    savedMetric = getSavedMetricByName(option);
+  }
+
+  if (option instanceof AdhocMetric || savedMetric) {
+    const adhocMetric =
+      option instanceof AdhocMetric ? option : new AdhocMetric({});
+
+    const metricOptionProps = {
+      onMetricEdit,
+      onRemoveMetric,
+      columns,
+      savedMetrics,
+      datasourceType,
+      adhocMetric,
+      onMoveLabel,
+      onDropLabel,
+      index,
+      savedMetric: savedMetric ?? {},
+    };
+
+    return <AdhocMetricOption {...metricOptionProps} />;
+  }
+  if (typeof option === 'string') {
+    return (
+      <DraggableOptionControlLabel
+        label={option}
+        onRemove={onRemoveMetric}
+        onMoveLabel={onMoveLabel}
+        onDropLabel={onDropLabel}
+        type={OPTION_TYPES.metric}
+        index={index}
+        isFunction
+      />
+    );
+  }
+  return null;
+}
+MetricDefinitionValue.propTypes = propTypes;