QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not add tag to non-saved objects (#7266)

Browse Source
This commit is contained in:
Beto Dealmeida
2019-04-09 20:51:42 -07:00
committed by GitHub
parent e505e326b2
commit 9856800cee
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/views/tags.py
View File

@@ -77,6 +77,9 @@ class TagView(BaseSupersetView):
@expose('/tags/<object_type:object_type>/<int:object_id>/', methods=['GET']) @expose('/tags/<object_type:object_type>/<int:object_id>/', methods=['GET'])
def get(self, object_type, object_id): def get(self, object_type, object_id):
"""List all tags a given object has.""" """List all tags a given object has."""
if object_id == 0:
return json_success(json.dumps([]))
query = db.session.query(TaggedObject).filter(and_( query = db.session.query(TaggedObject).filter(and_(
TaggedObject.object_type == object_type, TaggedObject.object_type == object_type,
TaggedObject.object_id == object_id)) TaggedObject.object_id == object_id))
@@ -87,6 +90,9 @@ class TagView(BaseSupersetView):
@expose('/tags/<object_type:object_type>/<int:object_id>/', methods=['POST']) @expose('/tags/<object_type:object_type>/<int:object_id>/', methods=['POST'])
def post(self, object_type, object_id): def post(self, object_type, object_id):
"""Add new tags to an object.""" """Add new tags to an object."""
if object_id == 0:
return Response(status=404)
tagged_objects = [] tagged_objects = []
for name in request.get_json(force=True): for name in request.get_json(force=True):
if ':' in name: if ':' in name: