QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-14 13:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): Make the View Chart In Explore menu option a link (#15668)

Browse Source 
* hey look, it's a real anchor tag!

* get the explore chart url into the link

* add doc comments to the functions

* remove pointless test

* update weird tests

Co-authored-by: Evan Rusackas <evan@preset.io>
This commit is contained in:
David Aaron Suddjian
2021-07-14 14:12:20 -07:00
committed by GitHub
parent 5d86b8dde6
commit 985af72ac3
6 changed files with 56 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
View File

@@ -193,18 +193,6 @@ test('Should not show export full CSV if report is not table', () => {
);
});
test('Should "View chart in Explore"', () => {
const props = createProps();
render(<SliceHeaderControls {...props} />, { useRedux: true });
expect(props.exploreChart).toBeCalledTimes(0);
userEvent.click(
screen.getByRole('menuitem', { name: 'View chart in Explore' }),
);
expect(props.exploreChart).toBeCalledTimes(1);
expect(props.exploreChart).toBeCalledWith(371);
});
test('Should "Toggle chart description"', () => {
const props = createProps();
render(<SliceHeaderControls {...props} />, { useRedux: true });