QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move raise_for_dashboard_access to security manager (#13235)

Browse Source 
raise_for_dashboard_access is part of dashboard and cannot
be overridden by a security manager.
This commit is contained in:
bolkedebruin
2021-02-23 11:52:34 +01:00
committed by GitHub
parent 6e3121268e
commit 99a0c8a8a1
3 changed files with 31 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset/utils/decorators.py
View File

@@ -19,7 +19,7 @@ from functools import wraps
from typing import Any, Callable, Dict, Iterator, Union
from contextlib2 import contextmanager
from flask import Response
from flask import current_app, Response
from superset import is_feature_enabled
from superset.dashboards.commands.exceptions import DashboardAccessDeniedError
@@ -87,15 +87,12 @@ def check_dashboard_access(
def decorator(f: Callable[..., Any]) -> Callable[..., Any]:
@wraps(f)
def wrapper(self: Any, *args: Any, **kwargs: Any) -> Any:
from superset.models.dashboard import (
Dashboard,
raise_for_dashboard_access,
)
from superset.models.dashboard import Dashboard
dashboard = Dashboard.get(str(kwargs["dashboard_id_or_slug"]))
if is_feature_enabled("DASHBOARD_RBAC"):
try:
raise_for_dashboard_access(dashboard)
current_app.appbuilder.sm.raise_for_dashboard_access(dashboard)
except DashboardAccessDeniedError as ex:
return on_error(self, ex)
except Exception as exception: