QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rename get_sqla_engine_with_context (#28012)

Browse Source
This commit is contained in:
Beto Dealmeida
2024-04-12 13:31:05 -04:00
committed by GitHub
parent 06077d42a8
commit 99a1601aea
45 changed files with 99 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit_tests/models/core_test.py
View File

@@ -220,7 +220,7 @@ def test_get_prequeries(mocker: MockFixture) -> None:
"""
mocker.patch.object(
Database,
"get_sqla_engine_with_context",
"get_sqla_engine",
)
db_engine_spec = mocker.patch.object(Database, "db_engine_spec")
db_engine_spec.get_prequeries.return_value = ["set a=1", "set b=2"]

6
tests/unit_tests/models/helpers_test.py
View File

@@ -54,13 +54,13 @@ def test_values_for_column(mocker: MockerFixture, session: Session) -> None:
# since we're using an in-memory SQLite database, make sure we always
# return the same engine where the table was created
@contextmanager
def mock_get_sqla_engine_with_context():
def mock_get_sqla_engine():
yield engine
mocker.patch.object(
database,
"get_sqla_engine_with_context",
new=mock_get_sqla_engine_with_context,
"get_sqla_engine",
new=mock_get_sqla_engine,
)
table = SqlaTable(