QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: adhoc filter 'equals' doesn't let you save (#9652)

Browse Source 
When altering a filter, when using `equals` or `does not equals`,
the save button is disabled even when it should be enalbed.
This commit is contained in:
Maxime Beauchemin
2020-05-06 08:38:10 -07:00
committed by GitHub
parent 292704fec9
commit 9aabafe9fe
4 changed files with 43 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
superset-frontend/spec/javascripts/explore/AdhocFilter_spec.js
View File

@@ -153,6 +153,36 @@ describe('AdhocFilter', () => {
});
// eslint-disable-next-line no-unused-expressions
expect(adhocFilter5.isValid()).toBe(true);
const adhocFilter6 = new AdhocFilter({
expressionType: EXPRESSION_TYPES.SIMPLE,
subject: 'value',
operator: '==',
comparator: 1,
clause: CLAUSES.WHERE,
});
// eslint-disable-next-line no-unused-expressions
expect(adhocFilter6.isValid()).toBe(true);
const adhocFilter7 = new AdhocFilter({
expressionType: EXPRESSION_TYPES.SIMPLE,
subject: 'value',
operator: '==',
comparator: 0,
clause: CLAUSES.WHERE,
});
// eslint-disable-next-line no-unused-expressions
expect(adhocFilter7.isValid()).toBe(true);
const adhocFilter8 = new AdhocFilter({
expressionType: EXPRESSION_TYPES.SIMPLE,
subject: 'value',
operator: '==',
comparator: null,
clause: CLAUSES.WHERE,
});
// eslint-disable-next-line no-unused-expressions
expect(adhocFilter8.isValid()).toBe(false);
});
it('can translate from simple expressions to sql expressions', () => {