QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-08 00:59:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): empty large query results from localStorage (#23302)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-03-13 16:03:19 -07:00
committed by GitHub
parent d415eed717
commit 9ae81b7c33
3 changed files with 56 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
View File

@@ -16,7 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from '../constants';
import {
BYTES_PER_CHAR,
KB_STORAGE,
LOCALSTORAGE_MAX_QUERY_AGE_MS,
LOCALSTORAGE_MAX_QUERY_RESULTS_KB,
} from '../constants';
const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
'remoteId',
@@ -36,13 +41,21 @@ const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
'hideLeftBar',
]);
function shouldEmptyQueryResults(query) {
const { startDttm, results } = query;
return (
Date.now() - startDttm > LOCALSTORAGE_MAX_QUERY_AGE_MS ||
((JSON.stringify(results)?.length || 0) * BYTES_PER_CHAR) / KB_STORAGE >
LOCALSTORAGE_MAX_QUERY_RESULTS_KB
);
}
export function emptyQueryResults(queries) {
return Object.keys(queries).reduce((accu, key) => {
const { startDttm, results } = queries[key];
const { results } = queries[key];
const query = {
...queries[key],
results:
Date.now() - startDttm > LOCALSTORAGE_MAX_QUERY_AGE_MS ? {} : results,
results: shouldEmptyQueryResults(queries[key]) ? {} : results,
};
const updatedQueries = {