QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(native-filters): Refactor filters config modal module (#13268)

Browse Source 
* refactor(native-filters): Refactor filters config modal module

* fix: fix import

* lint: fix import
This commit is contained in:
simcha90
2021-02-22 09:23:38 +02:00
committed by GitHub
parent e8d50356a2
commit 9b5e66b728
25 changed files with 1265 additions and 896 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/spec/javascripts/dashboard/components/nativeFilters/FilterScope_spec.tsx
View File

@@ -21,15 +21,15 @@ import { Provider } from 'react-redux';
import { render, screen, fireEvent } from 'spec/helpers/testing-library';
import { mockStoreWithChartsInTabsAndRoot } from 'spec/fixtures/mockStore';
import { Form, FormInstance } from 'src/common/components';
import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/FilterConfigModal/types';
import FilterConfigForm from 'src/dashboard/components/nativeFilters/FilterConfigModal/FilterConfigForm';
import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/FiltersConfigModal/types';
import FiltersConfigForm from 'src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm';
describe('FilterScope', () => {
const save = jest.fn();
let form: FormInstance<NativeFiltersForm>;
const mockedProps = {
filterId: 'DefaultFilterId',
restore: jest.fn(),
restoreFilter: jest.fn(),
parentFilters: [],
save,
};
@@ -49,7 +49,7 @@ describe('FilterScope', () => {
return (
<Provider store={mockStoreWithChartsInTabsAndRoot}>
<Form form={form}>
<FilterConfigForm form={form} {...mockedProps} />
<FiltersConfigForm form={form} {...mockedProps} />
</Form>
</Provider>
);

8
superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx
View File

@@ -21,10 +21,10 @@ import { styledMount as mount } from 'spec/helpers/theming';
import { act } from 'react-dom/test-utils';
import { ReactWrapper } from 'enzyme';
import { Provider } from 'react-redux';
import { FilterConfigModal } from 'src/dashboard/components/nativeFilters/FilterConfigModal/FilterConfigModal';
import Alert from 'src/components/Alert';
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
import { mockStore } from 'spec/fixtures/mockStore';
import { FiltersConfigModal } from 'src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal';
Object.defineProperty(window, 'matchMedia', {
writable: true,
@@ -61,18 +61,18 @@ describe('FiltersConfigModal', () => {
initialFilterId: 'DefaultsID',
createNewOnOpen: true,
onCancel: jest.fn(),
save: jest.fn(),
onSave: jest.fn(),
};
function setup(overridesProps?: any) {
return mount(
<Provider store={mockStore}>
<FilterConfigModal {...mockedProps} {...overridesProps} />
<FiltersConfigModal {...mockedProps} {...overridesProps} />
</Provider>,
);
}
it('should be a valid react element', () => {
expect(React.isValidElement(<FilterConfigModal {...mockedProps} />)).toBe(
expect(React.isValidElement(<FiltersConfigModal {...mockedProps} />)).toBe(
true,
);
});