QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 15:15:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dashboard] Fix URLShortLinkButton position after click anchor link (#7812)

Browse Source
This commit is contained in:
Grace Guo
2019-07-03 15:05:51 -07:00
committed by GitHub
parent 9dac805e7e
commit 9b8996038e
4 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset/assets/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx
View File

@@ -131,6 +131,17 @@ describe('Tabs', () => {
expect(onChangeTab.callCount).toBe(1);
});
it('should not call onChangeTab when anchor link is clicked', () => {
const onChangeTab = sinon.spy();
const wrapper = setup({ editMode: true, onChangeTab });
wrapper
.find('.dashboard-component-tabs .nav-tabs a .short-link-trigger')
.at(1) // will not call if it is already selected
.simulate('click');
expect(onChangeTab.callCount).toBe(0);
});
it('should render a HoverMenu in editMode', () => {
let wrapper = setup();
expect(wrapper.find(HoverMenu)).toHaveLength(0);