QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: only show active user for chart/dashboard/datasource owner drop… (#20837)

Browse Source
This commit is contained in:
Zef Lin
2022-09-06 11:17:50 -07:00
committed by GitHub
parent acd9515353
commit 9be4870c7f
6 changed files with 78 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/integration_tests/base_api_tests.py
View File

@@ -264,10 +264,26 @@ class ApiOwnersTestCaseMixin:
assert 4 == response["count"]
sorted_results = sorted(response["result"], key=lambda value: value["text"])
expected_results = [
{"text": "gamma user", "value": 2},
{"text": "gamma2 user", "value": 3},
{"text": "gamma_no_csv user", "value": 6},
{"text": "gamma_sqllab user", "value": 4},
{
"extra": {"active": True, "email": "gamma@fab.org"},
"text": "gamma user",
"value": 2,
},
{
"extra": {"active": True, "email": "gamma2@fab.org"},
"text": "gamma2 user",
"value": 3,
},
{
"extra": {"active": True, "email": "gamma_no_csv@fab.org"},
"text": "gamma_no_csv user",
"value": 6,
},
{
"extra": {"active": True, "email": "gamma_sqllab@fab.org"},
"text": "gamma_sqllab user",
"value": 4,
},
]
# TODO Check me
assert expected_results == sorted_results
@@ -286,8 +302,16 @@ class ApiOwnersTestCaseMixin:
assert 2 == response["count"]
sorted_results = sorted(response["result"], key=lambda value: value["text"])
expected_results = [
{"text": "gamma user", "value": 2},
{"text": "gamma_sqllab user", "value": 4},
{
"extra": {"active": True, "email": "gamma@fab.org"},
"text": "gamma user",
"value": 2,
},
{
"extra": {"active": True, "email": "gamma_sqllab@fab.org"},
"text": "gamma_sqllab user",
"value": 4,
},
]
assert expected_results == sorted_results
@@ -305,8 +329,16 @@ class ApiOwnersTestCaseMixin:
assert 2 == response["count"]
sorted_results = sorted(response["result"], key=lambda value: value["text"])
expected_results = [
{"text": "gamma user", "value": 2},
{"text": "gamma_sqllab user", "value": 4},
{
"extra": {"active": True, "email": "gamma@fab.org"},
"text": "gamma user",
"value": 2,
},
{
"extra": {"active": True, "email": "gamma_sqllab@fab.org"},
"text": "gamma_sqllab user",
"value": 4,
},
]
assert expected_results == sorted_results

3
tests/integration_tests/queries/saved_queries/api_tests.py
View File

@@ -445,7 +445,8 @@ class TestSavedQueryApi(SupersetTestCase):
expected_result = {
"count": len(databases),
"result": [
{"text": str(database), "value": database.id} for database in databases
{"extra": {}, "text": str(database), "value": database.id}
for database in databases
],
}