QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Jinja metric macro): Support Drill By and Excel/CSV download without a dataset ID (#30443)

Browse Source
This commit is contained in:
Vitor Avila
2024-10-10 21:03:19 -03:00
committed by GitHub
parent 0db59b45b8
commit 9c12b1c7da
3 changed files with 284 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/integration_tests/sqla_models_tests.py
View File

@@ -200,8 +200,8 @@ class TestDatabaseModel(SupersetTestCase):
db.session.delete(table)
db.session.commit()
@patch("superset.views.utils.get_form_data")
def test_jinja_metric_macro(self, mock_form_data_context):
@patch("superset.jinja_context.get_dataset_id_from_context")
def test_jinja_metric_macro(self, mock_dataset_id_from_context):
self.login(username="admin")
table = self.get_table(name="birth_names")
metric = SqlMetric(
@@ -234,14 +234,8 @@ class TestDatabaseModel(SupersetTestCase):
"filter": [],
"extras": {"time_grain_sqla": "P1D"},
}
mock_form_data_context.return_value = [
{
"url_params": {
"datasource_id": table.id,
}
},
None,
]
mock_dataset_id_from_context.return_value = table.id
sqla_query = table.get_sqla_query(**base_query_obj)
query = table.database.compile_sqla_query(sqla_query.sqla_query)