QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqla): replace custom dttm type with literal_column (#19917)

Browse Source 
(cherry picked from commit 99f1f9ec61)
This commit is contained in:
Ville Brofeldt
2022-05-03 07:19:36 +03:00
committed by Michael S. Molina
parent 2bd89d1705
commit 9ca53b8905
14 changed files with 63 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/integration_tests/db_engine_specs/presto_tests.py
View File

@@ -517,12 +517,12 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
self.assertEqual(
PrestoEngineSpec.convert_dttm("DATE", dttm),
"from_iso8601_date('2019-01-02')",
"DATE '2019-01-02'",
)
self.assertEqual(
PrestoEngineSpec.convert_dttm("TIMESTAMP", dttm),
"from_iso8601_timestamp('2019-01-02T03:04:05.678900')",
"TIMESTAMP '2019-01-02T03:04:05.678900'",
)
def test_query_cost_formatter(self):
@@ -672,12 +672,10 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
column_spec = PrestoEngineSpec.get_column_spec("time")
assert isinstance(column_spec.sqla_type, types.Time)
assert type(column_spec.sqla_type).__name__ == "TemporalWrapperType"
self.assertEqual(column_spec.generic_type, GenericDataType.TEMPORAL)
column_spec = PrestoEngineSpec.get_column_spec("timestamp")
assert isinstance(column_spec.sqla_type, types.TIMESTAMP)
assert type(column_spec.sqla_type).__name__ == "TemporalWrapperType"
self.assertEqual(column_spec.generic_type, GenericDataType.TEMPORAL)
sqla_type = PrestoEngineSpec.get_sqla_column_type(None)