QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-10 18:35:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993)" (#20092)

Browse Source 
This reverts commit ca9766c109.
This commit is contained in:
Kamil Gabryjelski
2022-05-17 14:56:31 +02:00
committed by GitHub
parent e69f6292c2
commit 9cdaa28042
5 changed files with 76 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
superset-frontend/src/explore/exploreUtils/formData.test.ts
View File

@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { sanitizeFormData, isEqualish } from './formData';
import { sanitizeFormData } from './formData';
test('sanitizeFormData removes temporary control values', () => {
expect(
@@ -26,25 +26,3 @@ test('sanitizeFormData removes temporary control values', () => {
}),
).toEqual({ metrics: ['foo', 'bar'] });
});
test('isEqualish', () => {
// considers null, undefined, {} and [] as equal
expect(isEqualish(null, undefined)).toBe(true);
expect(isEqualish(null, [])).toBe(true);
expect(isEqualish(null, {})).toBe(true);
expect(isEqualish(undefined, {})).toBe(true);
// considers empty strings are the same as null
expect(isEqualish(undefined, '')).toBe(true);
expect(isEqualish(null, '')).toBe(true);
// considers deeply equal objects as equal
expect(isEqualish('', '')).toBe(true);
expect(isEqualish({ a: 1, b: 2, c: 3 }, { a: 1, b: 2, c: 3 })).toBe(true);
// Out of order
expect(isEqualish({ a: 1, b: 2, c: 3 }, { b: 2, a: 1, c: 3 })).toBe(true);
// Actually not equal
expect(isEqualish({ a: 1, b: 2, z: 9 }, { a: 1, b: 2, c: 3 })).toBe(false);
});