QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove useless groupby from QueryObject (#21643)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-09-30 11:53:54 +08:00
committed by GitHub
parent f3465f5b22
commit 9dd102f383
4 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/plugins/plugin-chart-echarts/test/Gauge/buildQuery.test.ts
View File

@@ -29,20 +29,20 @@ describe('Gauge buildQuery', () => {
const formData = { ...baseFormData, groupby: undefined };
const queryContext = buildQuery(formData);
const [query] = queryContext.queries;
expect(query.groupby).toEqual([]);
expect(query.columns).toEqual([]);
});
it('should build query fields with single group by column', () => {
const formData = { ...baseFormData, groupby: ['foo'] };
const queryContext = buildQuery(formData);
const [query] = queryContext.queries;
expect(query.groupby).toEqual(['foo']);
expect(query.columns).toEqual(['foo']);
});
it('should build query fields with multiple group by columns', () => {
const formData = { ...baseFormData, groupby: ['foo', 'bar'] };
const queryContext = buildQuery(formData);
const [query] = queryContext.queries;
expect(query.groupby).toEqual(['foo', 'bar']);
expect(query.columns).toEqual(['foo', 'bar']);
});
});