mirror of
https://github.com/apache/superset.git
synced 2026-04-19 08:04:53 +00:00
test(alerts/reports): close backend and frontend test coverage gaps (#38591)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
52
tests/unit_tests/reports/api_test.py
Normal file
52
tests/unit_tests/reports/api_test.py
Normal file
@@ -0,0 +1,52 @@
|
||||
# Licensed to the Apache Software Foundation (ASF) under one
|
||||
# or more contributor license agreements. See the NOTICE file
|
||||
# distributed with this work for additional information
|
||||
# regarding copyright ownership. The ASF licenses this file
|
||||
# to you under the Apache License, Version 2.0 (the
|
||||
# "License"); you may not use this file except in compliance
|
||||
# with the License. You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing,
|
||||
# software distributed under the License is distributed on an
|
||||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
# KIND, either express or implied. See the License for the
|
||||
# specific language governing permissions and limitations
|
||||
# under the License.
|
||||
from typing import Any
|
||||
from unittest.mock import patch
|
||||
|
||||
import prison
|
||||
|
||||
from superset.exceptions import SupersetException
|
||||
from tests.unit_tests.conftest import with_feature_flags
|
||||
|
||||
|
||||
@with_feature_flags(ALERT_REPORTS=True)
|
||||
@patch("superset.reports.api.get_channels_with_search")
|
||||
def test_slack_channels_success(
|
||||
mock_search: Any,
|
||||
client: Any,
|
||||
full_api_access: None,
|
||||
) -> None:
|
||||
mock_search.return_value = [{"id": "C123", "name": "general"}]
|
||||
params = prison.dumps({})
|
||||
rv = client.get(f"/api/v1/report/slack_channels/?q={params}")
|
||||
assert rv.status_code == 200
|
||||
data = rv.json
|
||||
assert data["result"] == [{"id": "C123", "name": "general"}]
|
||||
|
||||
|
||||
@with_feature_flags(ALERT_REPORTS=True)
|
||||
@patch("superset.reports.api.get_channels_with_search")
|
||||
def test_slack_channels_handles_superset_exception(
|
||||
mock_search: Any,
|
||||
client: Any,
|
||||
full_api_access: None,
|
||||
) -> None:
|
||||
mock_search.side_effect = SupersetException("Slack API error")
|
||||
params = prison.dumps({})
|
||||
rv = client.get(f"/api/v1/report/slack_channels/?q={params}")
|
||||
assert rv.status_code == 422
|
||||
assert "Slack API error" in rv.json["message"]
|
||||
Reference in New Issue
Block a user