mirror of
https://github.com/apache/superset.git
synced 2026-05-12 19:35:17 +00:00
fix: enforce mandatory chart name on save and edit (#10482)
* fix: show empty charts as empty in chart list view * migrate ControlLabel to FormLabel and enforce requred fields * lint * reorder buttons
This commit is contained in:
@@ -262,18 +262,18 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
|
||||
</Row>
|
||||
</Modal.Body>
|
||||
<Modal.Footer>
|
||||
<Button type="button" bsSize="sm" onClick={onHide}>
|
||||
{t('Cancel')}
|
||||
</Button>
|
||||
<Button
|
||||
type="submit"
|
||||
bsSize="sm"
|
||||
bsStyle="primary"
|
||||
className="m-r-5"
|
||||
disabled={!owners || submitting}
|
||||
disabled={!owners || submitting || !name}
|
||||
>
|
||||
{t('Save')}
|
||||
</Button>
|
||||
<Button type="button" bsSize="sm" onClick={onHide}>
|
||||
{t('Cancel')}
|
||||
</Button>
|
||||
<Dialog ref={errorDialog} />
|
||||
</Modal.Footer>
|
||||
</form>
|
||||
|
||||
Reference in New Issue
Block a user