QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-09 08:15:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(query_context_processor): apply CSV encoding to follow the encoding settings of 'CSV_EXPORT' (#34806)

Browse Source 
Co-authored-by: Jeong Ju, Kim <haje01@webzen.com>
Co-authored-by: Evan <evan@preset.io>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Kim Jeong Ju
2026-06-15 00:55:25 +09:00
committed by GitHub
parent 9f81565625
commit 9ec9c8658b
4 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit_tests/common/test_query_context_processor.py
View File

@@ -107,7 +107,9 @@ def test_get_data_csv(mock_df_to_escaped_csv, processor, mock_query_context):
mock_df_to_escaped_csv.return_value = "col1,col2\n1,a\n2,b\n3,c\n"
result = processor.get_data(df, coltypes)
assert result == "col1,col2\n1,a\n2,b\n3,c\n"
# CSV output is encoded to bytes using the CSV_EXPORT encoding so dashboard
# chart exports honor the configured encoding (e.g. the utf-8-sig BOM).
assert result == "col1,col2\n1,a\n2,b\n3,c\n".encode("utf-8-sig")
mock_df_to_escaped_csv.assert_called_once_with(
df, index=False, encoding="utf-8-sig"
)
@@ -183,7 +185,7 @@ def test_get_data_empty_dataframe_csv(
mock_query_context.result_format = ChartDataResultFormat.CSV
mock_df_to_escaped_csv.return_value = "col1,col2\n"
result = processor.get_data(df, coltypes)
assert result == "col1,col2\n"
assert result == "col1,col2\n".encode("utf-8-sig")
mock_df_to_escaped_csv.assert_called_once_with(
df, index=False, encoding="utf-8-sig"
)