diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 06eb98116bb..4af4e743536 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -64,11 +64,17 @@ jobs: restore-keys: | pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}- + - name: Get changed files + id: changed_files + uses: ./.github/actions/file-changes-action + with: + output: ' ' + - name: pre-commit run: | set +e # Don't exit immediately on failure - export SKIP=eslint-frontend,type-checking-frontend - pre-commit run --all-files + export SKIP=type-checking-frontend + pre-commit run --files ${{ steps.changed_files.outputs.files }} PRE_COMMIT_EXIT_CODE=$? git diff --quiet --exit-code GIT_DIFF_EXIT_CODE=$? diff --git a/superset-frontend/oxlint.json b/superset-frontend/oxlint.json index a77625cd0d1..fb4401c4bab 100644 --- a/superset-frontend/oxlint.json +++ b/superset-frontend/oxlint.json @@ -237,8 +237,7 @@ "jsx-a11y/no-noninteractive-tabindex": "error", "jsx-a11y/no-redundant-roles": "error", "jsx-a11y/no-static-element-interactions": "off", - // TODO: Fix missing aria-selected on tab roles - "jsx-a11y/role-has-required-aria-props": "warn", + "jsx-a11y/role-has-required-aria-props": "error", "jsx-a11y/role-supports-aria-props": "error", "jsx-a11y/scope": "error", "jsx-a11y/tabindex-no-positive": "error", diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx index 343be64c6f3..b04a63ecf6d 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx @@ -168,6 +168,7 @@ const FilterTitleContainer = forwardRef( key={`filter-title-tab-${id}`} onClick={() => onChange(id)} className={classNames.join(' ')} + aria-selected={isActive} >
( key={`item-title-tab-${id}`} onClick={() => onChange(id)} className={classNames.join(' ')} + aria-selected={isActive} >