feat: Move cross filters to Dashboard (#22785)

This commit is contained in:
Geido
2023-01-25 18:01:06 +01:00
committed by GitHub
parent 262c947273
commit 9ed2326a20
87 changed files with 814 additions and 640 deletions

View File

@@ -30,12 +30,12 @@ export default function EchartsGauge(props: GaugeChartTransformedProps) {
labelMap,
groupby,
selectedValues,
formData: { emitFilter },
emitCrossFilters,
refs,
} = props;
const handleChange = useCallback(
(values: string[]) => {
if (!emitFilter) {
if (!emitCrossFilters) {
return;
}

View File

@@ -23,7 +23,6 @@ import {
ControlPanelConfig,
D3_FORMAT_OPTIONS,
sections,
emitFilterControl,
getStandardizedControls,
} from '@superset-ui/chart-controls';
import { DEFAULT_FORM_DATA } from './types';
@@ -46,7 +45,6 @@ const config: ControlPanelConfig = {
],
['metric'],
['adhoc_filters'],
emitFilterControl,
[
{
name: 'row_limit',

View File

@@ -91,8 +91,16 @@ const calculateMax = (data: GaugeDataItemOption[]) =>
export default function transformProps(
chartProps: EchartsGaugeChartProps,
): GaugeChartTransformedProps {
const { width, height, formData, queriesData, hooks, filterState, theme } =
chartProps;
const {
width,
height,
formData,
queriesData,
hooks,
filterState,
theme,
emitCrossFilters,
} = chartProps;
const gaugeSeriesOptions = defaultGaugeSeriesOption(theme);
@@ -117,7 +125,6 @@ export default function transformProps(
intervals,
intervalColorIndices,
valueFormatter,
emitFilter,
sliceId,
}: EchartsGaugeFormData = { ...DEFAULT_GAUGE_FORM_DATA, ...formData };
const refs: Refs = {};
@@ -327,7 +334,7 @@ export default function transformProps(
height,
echartOptions,
setDataMask,
emitFilter,
emitCrossFilters,
labelMap: Object.fromEntries(columnsLabelMap),
groupby,
selectedValues: filterState.selectedValues || [],

View File

@@ -52,7 +52,6 @@ export type EchartsGaugeFormData = QueryFormData & {
intervals: string;
intervalColorIndices: string;
valueFormatter: string;
emitFilter: boolean;
};
export const DEFAULT_FORM_DATA: Partial<EchartsGaugeFormData> = {
@@ -76,7 +75,6 @@ export const DEFAULT_FORM_DATA: Partial<EchartsGaugeFormData> = {
intervals: '',
intervalColorIndices: '',
valueFormatter: '{value}',
emitFilter: false,
};
export interface EchartsGaugeChartProps