QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-25 11:04:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Move cross filters to Dashboard (#22785)

Browse Source
This commit is contained in:
Geido
2023-01-25 18:01:06 +01:00
committed by GitHub
parent 262c947273
commit 9ed2326a20
87 changed files with 814 additions and 640 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx
View File

@@ -135,7 +135,7 @@ export default function PivotTableChart(props: PivotTableProps) {
colTotals,
rowTotals,
valueFormat,
emitFilter,
emitCrossFilters,
setDataMask,
selectedFilters,
verboseMap,
@@ -287,7 +287,7 @@ export default function PivotTableChart(props: PivotTableProps) {
isSubtotal: boolean,
isGrandTotal: boolean,
) => {
if (isSubtotal || isGrandTotal || !emitFilter) {
if (isSubtotal || isGrandTotal || !emitCrossFilters) {
return;
}
@@ -327,7 +327,7 @@ export default function PivotTableChart(props: PivotTableProps) {
}
handleChange(updatedFilters);
},
[emitFilter, selectedFilters, handleChange],
[emitCrossFilters, selectedFilters, handleChange],
);
const tableOptions = useMemo(
@@ -336,7 +336,7 @@ export default function PivotTableChart(props: PivotTableProps) {
clickColumnHeaderCallback: toggleFilter,
colTotals,
rowTotals,
highlightHeaderCellsOnHover: emitFilter,
highlightHeaderCellsOnHover: emitCrossFilters,
highlightedHeaderCells: selectedFilters,
omittedHighlightHeaderGroups: [METRIC_KEY],
cellColorFormatters: { [METRIC_KEY]: metricColorFormatters },
@@ -345,7 +345,7 @@ export default function PivotTableChart(props: PivotTableProps) {
[
colTotals,
dateFormatters,
emitFilter,
emitCrossFilters,
metricColorFormatters,
rowTotals,
selectedFilters,

2
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
View File

@@ -32,7 +32,6 @@ import {
D3_TIME_FORMAT_OPTIONS,
sections,
sharedControls,
emitFilterControl,
Dataset,
getStandardizedControls,
} from '@superset-ui/chart-controls';
@@ -127,7 +126,6 @@ const config: ControlPanelConfig = {
},
],
['adhoc_filters'],
emitFilterControl,
['series_limit'],
[
{

4
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/transformProps.ts
View File

@@ -80,6 +80,7 @@ export default function transformProps(chartProps: ChartProps<QueryFormData>) {
hooks: { setDataMask = () => {}, onContextMenu },
filterState,
datasource: { verboseMap = {}, columnFormats = {} },
emitCrossFilters,
} = chartProps;
const { data, colnames, coltypes } = queriesData[0];
const {
@@ -98,7 +99,6 @@ export default function transformProps(chartProps: ChartProps<QueryFormData>) {
rowTotals,
valueFormat,
dateFormat,
emitFilter,
metricsLayout,
conditionalFormatting,
timeGrainSqla,
@@ -157,7 +157,7 @@ export default function transformProps(chartProps: ChartProps<QueryFormData>) {
colTotals,
rowTotals,
valueFormat,
emitFilter,
emitCrossFilters,
setDataMask,
selectedFilters,
verboseMap,

2
superset-frontend/plugins/plugin-chart-pivot-table/src/types.ts
View File

@@ -65,7 +65,7 @@ interface PivotTableCustomizeProps {
rowTotals: boolean;
valueFormat: string;
setDataMask: SetDataMaskHook;
emitFilter?: boolean;
emitCrossFilters?: boolean;
selectedFilters?: SelectedFiltersType;
verboseMap: JsonObject;
columnFormats: JsonObject;