QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Move cross filters to Dashboard (#22785)

Browse Source
This commit is contained in:
Geido
2023-01-25 18:01:06 +01:00
committed by GitHub
parent 262c947273
commit 9ed2326a20
87 changed files with 814 additions and 640 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx
View File

@@ -135,7 +135,7 @@ export default function PivotTableChart(props: PivotTableProps) {
colTotals,
rowTotals,
valueFormat,
emitFilter,
emitCrossFilters,
setDataMask,
selectedFilters,
verboseMap,
@@ -287,7 +287,7 @@ export default function PivotTableChart(props: PivotTableProps) {
isSubtotal: boolean,
isGrandTotal: boolean,
) => {
if (isSubtotal || isGrandTotal || !emitFilter) {
if (isSubtotal || isGrandTotal || !emitCrossFilters) {
return;
}
@@ -327,7 +327,7 @@ export default function PivotTableChart(props: PivotTableProps) {
}
handleChange(updatedFilters);
},
[emitFilter, selectedFilters, handleChange],
[emitCrossFilters, selectedFilters, handleChange],
);
const tableOptions = useMemo(
@@ -336,7 +336,7 @@ export default function PivotTableChart(props: PivotTableProps) {
clickColumnHeaderCallback: toggleFilter,
colTotals,
rowTotals,
highlightHeaderCellsOnHover: emitFilter,
highlightHeaderCellsOnHover: emitCrossFilters,
highlightedHeaderCells: selectedFilters,
omittedHighlightHeaderGroups: [METRIC_KEY],
cellColorFormatters: { [METRIC_KEY]: metricColorFormatters },
@@ -345,7 +345,7 @@ export default function PivotTableChart(props: PivotTableProps) {
[
colTotals,
dateFormatters,
emitFilter,
emitCrossFilters,
metricColorFormatters,
rowTotals,
selectedFilters,