QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revise markup.js and iframe.js (#5672)

Browse Source 
* Do not call slice.xxx

* remove iframe id

* remove old code

* use import instead of require

* update iframe.js
This commit is contained in:
Krist Wongsuphasawat
2018-08-23 15:45:45 -07:00
committed by Chris Williams
parent 5c49514e2f
commit 9fb28b5f4e
3 changed files with 42 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
superset/assets/src/visualizations/iframe.js
View File

@@ -1,12 +1,20 @@
const $ = require('jquery');
import Mustache from 'mustache';
function iframeWidget(slice) {
$('#code').attr('rows', '15');
const url = slice.render_template(slice.formData.url);
slice.container.html('<iframe style="width:100%;"></iframe>');
const iframe = slice.container.find('iframe');
iframe.css('height', slice.height());
iframe.attr('src', url);
export default function iframeWidget(slice) {
const { selector, formData } = slice;
const { url } = formData;
const width = slice.width();
const height = slice.height();
const container = document.querySelector(selector);
const completedUrl = Mustache.render(url, {
width,
height,
});
const iframe = document.createElement('iframe');
iframe.style.width = '100%';
iframe.style.height = height;
iframe.setAttribute('src', completedUrl);
container.appendChild(iframe);
}
module.exports = iframeWidget;