[ci] Deprecate flake8 (#8409)

* [ci] Deprecate flake8

* Addressing @villebro's comments
This commit is contained in:
John Bodley
2019-10-18 14:44:27 -07:00
committed by Maxime Beauchemin
parent a19990185d
commit 9fc37ea9f1
234 changed files with 702 additions and 647 deletions

View File

@@ -15,26 +15,24 @@
# specific language governing permissions and limitations
# under the License.
# pylint: disable=C,R,W
from datetime import datetime
import functools
import logging
import traceback
from datetime import datetime
from typing import Any, Dict
import simplejson as json
import yaml
from flask import abort, flash, g, get_flashed_messages, redirect, Response
from flask_appbuilder import BaseView, ModelView
from flask_appbuilder.actions import action
from flask_appbuilder.forms import DynamicForm
from flask_appbuilder.models.sqla.filters import BaseFilter
from flask_appbuilder.widgets import ListWidget
from flask_babel import get_locale
from flask_babel import gettext as __
from flask_babel import lazy_gettext as _
from flask_babel import get_locale, gettext as __, lazy_gettext as _
from flask_wtf.form import FlaskForm
import simplejson as json
from werkzeug.exceptions import HTTPException
from wtforms.fields.core import Field, UnboundField
import yaml
from superset import conf, db, get_feature_flags, security_manager
from superset.exceptions import SupersetException, SupersetSecurityException
@@ -200,7 +198,7 @@ class ListWidgetWithCheckboxes(ListWidget):
template = "superset/fab_overrides/list_with_checkboxes.html"
def validate_json(form, field): # noqa
def validate_json(form, field):
try:
json.loads(field.data)
except Exception as e:
@@ -335,7 +333,7 @@ class SupersetFilter(BaseFilter):
class DatasourceFilter(SupersetFilter):
def apply(self, query, func): # noqa
def apply(self, query, func):
if security_manager.all_datasource_access():
return query
perms = self.get_view_menus("datasource_access")
@@ -348,7 +346,7 @@ class CsvResponse(Response):
Override Response to take into account csv encoding from config.py
"""
charset = conf.get("CSV_EXPORT").get("encoding", "utf-8")
charset = conf["CSV_EXPORT"].get("encoding", "utf-8")
def check_ownership(obj, raise_if_false=True):