QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-27 17:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(db): use Dialect instead of Engine in select_star to avoid SSH tunnels (#35540)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit e9b494163b)
This commit is contained in:
Elizabeth Thompson
2026-02-02 10:26:35 -08:00
committed by Joe Li
parent 221bbd6d41
commit a1a4ca0238
10 changed files with 33 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit_tests/db_engine_specs/test_postgres.py
View File

@@ -252,7 +252,7 @@ def test_select_star(mocker: MockerFixture) -> None:
Test the ``select_star`` method.
"""
database = mocker.MagicMock()
engine = mocker.MagicMock()
dialect = mocker.MagicMock()
def quote_table(table: Table, dialect: Dialect) -> str:
return ".".join(
@@ -264,7 +264,7 @@ def test_select_star(mocker: MockerFixture) -> None:
spec.select_star(
database=database,
table=Table("my_table", "my_schema", "my_catalog"),
engine=engine,
dialect=dialect,
limit=100,
show_cols=False,
indent=True,