From a3106bcb3d0bc6fb0e5df2c356d453563a07c8a2 Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Sat, 3 Dec 2016 20:05:43 -0800
Subject: [PATCH] [bugfix] bignumber comparison wrong with neg values (#1743)

* [bugfix] bignumber comparison wrong with neg values

* Handling zero div
---
 superset/assets/visualizations/big_number.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/assets/visualizations/big_number.js b/superset/assets/visualizations/big_number.js
index 2a5c68161c8..2f9949243ae 100644
--- a/superset/assets/visualizations/big_number.js
+++ b/superset/assets/visualizations/big_number.js
@@ -35,7 +35,10 @@ function bigNumberVis(slice) {
       if (json.compare_lag > 0) {
         const pos = data.length - (json.compare_lag + 1);
         if (pos >= 0) {
-          vCompare = (v / data[pos][1]) - 1;
+          const vAnchor = data[pos][1];
+          if (vAnchor !== 0) {
+            vCompare = (v - vAnchor) / Math.abs(vAnchor);
+          }
         }
       }
       const dateExt = d3.extent(data, (d) => d[0]);