[sql lab] improvements to the left panel (#2709)

* [sql lab] improvements to the left panel

* better error handling with error notifications
* table is added instantly with a loading image

* Fixing tests

* Fixed tests
This commit is contained in:
Maxime Beauchemin
2017-05-09 13:36:10 -07:00
committed by GitHub
parent 5d0a01d0d0
commit a471afe206
8 changed files with 194 additions and 119 deletions

View File

@@ -1,10 +1,9 @@
import React from 'react';
import Select from 'react-select';
import { shallow } from 'enzyme';
import { mount, shallow } from 'enzyme';
import { describe, it } from 'mocha';
import { expect } from 'chai';
import sinon from 'sinon';
import $ from 'jquery';
import AsyncSelect from '../../../javascripts/components/AsyncSelect';
@@ -39,30 +38,32 @@ describe('AsyncSelect', () => {
});
describe('auto select', () => {
let stub;
let server;
beforeEach(() => {
stub = sinon.stub($, 'get');
stub.yields();
server = sinon.fakeServer.create();
server.respondWith([
200, { 'Content-Type': 'application/json' }, JSON.stringify({}),
]);
});
afterEach(() => {
stub.restore();
server.restore();
});
it('should be off by default', () => {
const wrapper = shallow(
const wrapper = mount(
<AsyncSelect {...mockedProps} />,
);
const spy = sinon.spy(wrapper.instance(), 'onChange');
wrapper.instance().fetchOptions();
expect(spy.callCount).to.equal(0);
});
it('should auto select first option', () => {
const wrapper = shallow(
const wrapper = mount(
<AsyncSelect {...mockedProps} autoSelect />,
);
const spy = sinon.spy(wrapper.instance(), 'onChange');
wrapper.instance().fetchOptions();
server.respond();
expect(spy.callCount).to.equal(1);
expect(spy.calledWith(wrapper.instance().state.options[0])).to.equal(true);
});
});