QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 22:29:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow only dttm columns in comparison filter in Period over Period chart (#27209)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2024-03-05 21:24:26 +01:00
committed by GitHub
parent a3d2e0bf44
commit a4c771e013
2 changed files with 41 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx
View File

@@ -382,7 +382,18 @@ const DndFilterSelect = (props: DndFilterSelectProps) => {
return new AdhocFilter(config);
}, [droppedItem]);
const canDrop = useCallback(() => true, []);
const canDrop = useCallback(
(item: DatasourcePanelDndItem) => {
if (item.type === DndItemType.Column) {
return props.columns.some(
col => col.column_name === (item.value as ColumnMeta).column_name,
);
}
return true;
},
[props.columns],
);
const handleDrop = useCallback(
(item: DatasourcePanelDndItem) => {
setDroppedItem(item.value);