mirror of
https://github.com/apache/superset.git
synced 2026-05-31 13:19:23 +00:00
fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching * Fix metrics and filters popover being stale after reordering
This commit is contained in:
committed by
GitHub
parent
2c595b09ea
commit
a547dcb73e
@@ -35,7 +35,6 @@ export type AdhocMetricPopoverTriggerProps = {
|
||||
savedMetric: savedMetricType;
|
||||
datasourceType: string;
|
||||
children: ReactNode;
|
||||
createNew?: boolean;
|
||||
isControlledComponent?: boolean;
|
||||
visible?: boolean;
|
||||
togglePopover?: (visible: boolean) => void;
|
||||
@@ -232,7 +231,7 @@ class AdhocMetricPopoverTrigger extends React.PureComponent<
|
||||
visible={visible}
|
||||
onVisibleChange={togglePopover}
|
||||
title={popoverTitle}
|
||||
destroyTooltipOnHide={this.props.createNew}
|
||||
destroyTooltipOnHide
|
||||
>
|
||||
{this.props.children}
|
||||
</Popover>
|
||||
|
||||
@@ -236,7 +236,6 @@ const MetricsControl = ({
|
||||
datasource={datasource}
|
||||
savedMetric={emptySavedMetric}
|
||||
datasourceType={datasourceType}
|
||||
createNew
|
||||
>
|
||||
{trigger}
|
||||
</AdhocMetricPopoverTrigger>
|
||||
|
||||
Reference in New Issue
Block a user