QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Consider default catalog when getting tables and view lists (#33916)

Browse Source
This commit is contained in:
Vitor Avila
2025-06-26 13:55:10 -03:00
committed by GitHub
parent 8b5afc6f29
commit a56d7252c2
4 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/integration_tests/databases/commands_tests.py
View File

@@ -1202,3 +1202,44 @@ class TestTablesDatabaseCommand(SupersetTestCase):
assert result["count"] > 0
assert len(result["result"]) > 0
assert len(result["result"]) == result["count"]
@patch("superset.daos.database.DatabaseDAO.find_by_id")
@patch("superset.security.manager.SupersetSecurityManager.can_access_database")
@patch("superset.utils.core.g")
def test_database_tables_list_tables_default_catalog(
self, mock_g, mock_can_access_database, mock_find_by_id
):
database = get_example_database()
mock_find_by_id.return_value = database
mock_can_access_database.return_value = True
mock_g.user = security_manager.find_user("admin")
with (
patch.object(
database, "get_default_catalog", return_value="default_catalog"
),
patch.object(
database, "get_all_table_names_in_schema", return_value=[]
) as mock_get_all_table_names,
patch.object(
database, "get_all_view_names_in_schema", return_value=[]
) as mock_get_all_view_names,
):
command = TablesDatabaseCommand(database.id, None, "schema_name", False)
command.run()
# Assert that the default catalog is used instead of None
mock_get_all_table_names.assert_called_once_with(
catalog="default_catalog",
schema="schema_name",
force=False,
cache=database.table_cache_enabled,
cache_timeout=database.table_cache_timeout,
)
mock_get_all_view_names.assert_called_once_with(
catalog="default_catalog",
schema="schema_name",
force=False,
cache=database.table_cache_enabled,
cache_timeout=database.table_cache_timeout,
)