QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-04 15:19:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Verify when null value should be undefined in Select (#17013)

Browse Source 
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
This commit is contained in:
Geido
2021-10-08 17:32:09 +03:00
committed by GitHub
parent 42efcdf027
commit a57ae35011
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/src/explore/components/controls/SelectControl.jsx
View File

@@ -205,6 +205,21 @@ export default class SelectControl extends React.PureComponent {
danger,
};
const getValue = () => {
const currentValue =
value ||
(this.props.default !== undefined ? this.props.default : undefined);
// safety check - the value is intended to be undefined but null was used
if (
currentValue === null &&
!this.state.options.find(o => o.value === null)
) {
return undefined;
}
return currentValue;
};
const selectProps = {
allowNewOptions: freeForm,
autoFocus,
@@ -225,9 +240,7 @@ export default class SelectControl extends React.PureComponent {
optionRenderer,
options: this.state.options,
placeholder,
value:
value ||
(this.props.default !== undefined ? this.props.default : undefined),
value: getValue(),
};
return (