QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-01 13:49:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Add ESLint rule to enforce sentence case in button text (#34434)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Joe Li
2025-08-06 13:13:36 -07:00
committed by GitHub
parent 3e12d97e8e
commit a66b7e98e0
30 changed files with 183 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
View File

@@ -849,7 +849,7 @@ class AnnotationLayer extends PureComponent {
buttonSize="xsmall"
onClick={() => this.setState({ color: AUTOMATIC_COLOR })}
>
{t('Automatic Color')}
{t('Automatic color')}
</Button>
</div>
</div>

2
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
View File

@@ -220,7 +220,7 @@ test('keeps apply disabled when missing required fields', async () => {
expect(await screen.findByText('Chart A')).toBeInTheDocument();
userEvent.click(screen.getByText('Chart A'));
await screen.findByText(/title column/i);
userEvent.click(screen.getByRole('button', { name: 'Automatic Color' }));
userEvent.click(screen.getByRole('button', { name: 'Automatic color' }));
userEvent.click(
screen.getByRole('combobox', { name: 'Annotation layer title column' }),
);