QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 11:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Filter and Metric popovers not closing after clicking Save (#11607)

Browse Source 
* Fix filter popover not closing

* Fix metric popover not closing

* Add e2e tests
This commit is contained in:
Kamil Gabryjelski
2020-11-06 23:23:12 +01:00
committed by GitHub
parent 32e52e94e0
commit a6bf95e30b
5 changed files with 38 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx
View File

@@ -85,7 +85,8 @@ export default class AdhocFilterEditPopover extends React.Component {
}
onSave() {
this.props.onChange(this.state.adhocFilter);
// unset isNew here in case save button was clicked when no changes were made
this.props.onChange({ ...this.state.adhocFilter, isNew: false });
this.props.onClose();
}
@@ -163,7 +164,7 @@ export default class AdhocFilterEditPopover extends React.Component {
datasource={datasource}
onHeightChange={this.adjustHeight}
partitionColumn={partitionColumn}
popoverRef={this.popoverContentRef}
popoverRef={this.popoverContentRef.current}
/>
</Tabs.TabPane>
<Tabs.TabPane

2
superset-frontend/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
View File

@@ -100,7 +100,7 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon
};
this.menuPortalProps = {
menuPortalTarget: props.popoverRef?.current || document.body,
menuPortalTarget: props.popoverRef,
menuPosition: 'fixed',
menuPlacement: 'bottom',
};

2
superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx
View File

@@ -100,9 +100,11 @@ export default class AdhocMetricEditPopover extends React.Component {
}
onSave() {
// unset isNew here in case save button was clicked when no changes were made
this.props.onChange({
...this.state.adhocMetric,
...this.props.title,
isNew: false,
});
this.props.onClose();
}